Fix DPoPInterceptor thread-safety #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MessageDigest is not thread-safe, wrap in a ThreadLocal
arvindkrishnakumar-okta
changed the base branch from
master
to
fix_dpop_thread_safety
arvindkrishnakumar-okta
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
When ApiClient is used concurrently (either with a single or multiple instances) with DPoP enabled, it will eventually fail with an invalid ath DPoP claim error.
This is caused by the static MessageDigest in DPoPInterceptor not being thread safe, and returning invalid token hashes if used from multiple threads.
=> wrap the static field in a ThreadLocal to get an instance per thread.
Description
Category
Signoff