-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #491
Update README.md #491
Conversation
README.md
Outdated
### Prerequisites | ||
|
||
* JDK 8 or later | ||
* Apache Maven (3.6.x or later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any build system could be used, gradle, ivy, etc. (though we likely would only support Maven or Gradle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just leave the build system off completely, or maybe just say the artifacts are published to Maven Central
(it's similar to the Node JS world, you could use yarn or NPM, it's mostly an implementation detail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (left the build system off completely).
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=========================================
Coverage 81.22% 81.22%
Complexity 966 966
=========================================
Files 121 121
Lines 3227 3228 +1
Branches 409 410 +1
=========================================
+ Hits 2621 2622 +1
Misses 421 421
Partials 185 185
Continue to review full report at Codecov.
|
Issue(s)
#489
Description
Add a note on JDK prerequisite to README.
Category