Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #491

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Nov 23, 2020

Issue(s)

#489

Description

Add a note on JDK prerequisite to README.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Configuration Change
  • Versioning Change
  • Unit Test(s)
  • Documentation

README.md Outdated
### Prerequisites

* JDK 8 or later
* Apache Maven (3.6.x or later)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any build system could be used, gradle, ivy, etc. (though we likely would only support Maven or Gradle)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just leave the build system off completely, or maybe just say the artifacts are published to Maven Central

(it's similar to the Node JS world, you could use yarn or NPM, it's mostly an implementation detail)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (left the build system off completely).

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #491 (0b0ed24) into master (9e53cb2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #491   +/-   ##
=========================================
  Coverage     81.22%   81.22%           
  Complexity      966      966           
=========================================
  Files           121      121           
  Lines          3227     3228    +1     
  Branches        409      410    +1     
=========================================
+ Hits           2621     2622    +1     
  Misses          421      421           
  Partials        185      185           
Impacted Files Coverage Δ Complexity Δ
...ta/sdk/impl/resource/OktaResourceHrefResolver.java 90.00% <0.00%> (+0.34%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e53cb2...3a56c02. Read the comment docs.

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 2d182b8 into master Nov 24, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the readme_update_java_maven_requirements branch November 24, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants