Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of polymorphic types when discriminator property is unknown or null #981

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Feb 9, 2024

Issue(s)

Description

This is a copy of the original PR from @clementdenis - #980

Thanks to @clementdenis for the PR!

(copied for testing, building with CCI and merge to master/main branch)

  • Cleanup remaining custom polymorphic MixIns
  • Add defaultImpl to @JsonTypeInfo annotation
  • Handles cases where the discriminator is null, like Directory Integration apps

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

…is unknown or null (#980)

* Cleanup remaining custom polymorphic MixIns

* Add defaultImpl to @JsonTypeInfo annotation
- Handles cases where the discriminator is null, like Directory Integration apps
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 5713c56 into master Mar 29, 2024
9 of 10 checks passed
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the merge_pr_980 branch March 29, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants