Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support required params validation - OKTA-332240 #205

Merged
merged 6 commits into from
Oct 13, 2020
Merged

feat: support required params validation - OKTA-332240 #205

merged 6 commits into from
Oct 13, 2020

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Oct 8, 2020

Resolves: #200

@shuowu shuowu mentioned this pull request Oct 8, 2020
Closed
@swiftone swiftone self-requested a review October 9, 2020 20:07
swiftone
swiftone approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@swiftone swiftone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in Slack about making sure we're all branching the same way

@shuowu-okta shuowu-okta merged commit c59b3a7 into master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftone swiftone swiftone approved these changes

@aarongranick-okta aarongranick-okta Awaiting requested review from aarongranick-okta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getUser hangs if id is an empty string
3 participants
@shuowu @swiftone @shuowu-okta