Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Luxu2-Okta committed Jun 24, 2024
1 parent ec9eede commit 26ee3ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion playground/mocks/config/responseConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ const windowAuthnLoopbackFailfast = {
],
};

const windowAuthnHttpsLoopback = {
const macOSAuthnHttpsLoopback = {
'/idp/idx/introspect': [
'identify-with-device-probing-https-loopback', // 1 (response order)
],
Expand Down
2 changes: 2 additions & 0 deletions src/v2/view-builder/internals/BaseOktaVerifyChallengeView.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint max-statements: [2, 21] */
import { $, View } from '@okta/courage';
import { BaseFormWithPolling } from '../internals';
import Logger from 'util/Logger';
Expand Down Expand Up @@ -163,6 +164,7 @@ const Body = BaseFormWithPolling.extend({
// This only applies to MacOS for now
if (authenticatorHttpsDomainUrl) {
// if https domain are included, max number of ports to be probed should be doubled
Logger.info('httpsDomain enabled, will probe and challenge https first');
maxNumberOfPorts += maxNumberOfPorts;
ports.forEach(port => {
probeChain = probeChain
Expand Down

0 comments on commit 26ee3ec

Please sign in to comment.