-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry poc #3294
base: master
Are you sure you want to change the base?
sentry poc #3294
Conversation
3045f79
to
d952f63
Compare
This reverts commit a9a6396.
f756175
to
a680fb8
Compare
@@ -19,7 +19,7 @@ export default BaseFooter.extend({ | |||
SignUpLinkWithText = View.extend({ | |||
className: 'signup-info', | |||
template: hbs` | |||
<span>{{i18n code="registration.signup.label" bundle="login"}}</span><span class="signup-link"></span> | |||
<span>{{i18n code="registration.signup.label000" bundle="login"}}</span><span class="signup-link"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to trigger translation error
|
||
// First run fetchInitialData, in case the next controller needs data | ||
// before it's initial render. This will leave the current page in a | ||
// loading state. | ||
return this.controller | ||
.fetchInitialData() | ||
return createControllerAndFetchInitialData() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap controller initialisation in async function to catch errors in .catch()
@@ -267,6 +272,9 @@ export default Router.extend({ | |||
oldController.remove(); | |||
oldController.$el.remove(); | |||
} | |||
|
|||
// to catch errors like https://github.com/okta/okta-signin-widget/pull/3276 | |||
this.settings.callGlobalError(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to catch errors like #3276
Internal ref: OKTA-550082
Sentry fork: denysoblohin-okta/sentry-javascript#1
See sentry.md