-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: Use minimal okta-auth-js IDX client #3419
base: master
Are you sure you want to change the base?
Conversation
include: [ | ||
/node_modules\/@okta\/okta-auth-js/, | ||
], | ||
sideEffects: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important for proper tree-shaking
@@ -320,10 +320,8 @@ test.requestHooks(requestLogger, mockEnrollAuthenticatorPhoneSmsInvalidPhone)('s | |||
await t.expect(req3Body?.authenticator?.phoneNumber).eql('+1123'); | |||
await t.expect(req3Body?.stateHandle).notEql(undefined); | |||
|
|||
// in gen 2 we re-introspect when clicking return to authenticator, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in okta/okta-auth-js#1426
@@ -98,7 +99,6 @@ Expect.describe('v1/LoginRouter', function() { | |||
router.on('afterError', afterErrorHandler); | |||
if (authClient) { | |||
spyOn(authClient.token, 'getWithoutPrompt').and.callThrough(); | |||
spyOn(authClient.token.getWithRedirect, '_setLocation'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_setLocation
has been removed in okta/okta-auth-js#1324
4c54151
to
79e27c3
Compare
2d415f4
to
5cf248f
Compare
AUTHJS_VERSION="7.5.0-ga548153" use idx as before, but create own lite OktaAuthClient use 7.5.0-g5555ddd fix test fix test fix test type fixes lint fix fix lint trigger test 7.5.0-g5ab8355 increase timeout
This reverts commit c5b0a21.
. . . .
8e97a72
to
7d0e238
Compare
Description:
Use client from okta/okta-auth-js#1476
Size comparison:
Before:
After:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: