OKTA-719439 Support HTTPS loopback server call #3605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playground/mocks/data/idp/idx/identify-with-device-probing-https-loopback.json
Show resolved
Hide resolved
| 'authenticator-verification-select-authenticator', | ||
| ] | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can you explain the purpose of windowAuthnHttpsLoopback variable? I don't see it used in any test file.
| .respond((req, res) => { | ||
| res.statusCode = '200'; | ||
| res.headers['content-type'] = 'application/json'; | ||
| if (failureCount === 2) { |
There was a problem hiding this comment.
What does failureCount refer to? 500 error while probing?
| await t.expect(loopbackSuccessLogger.count( | ||
| record => record.response.statusCode === 500 && | ||
| record.request.url.match(/randomorgid.authenticatorlocaldev.com:6513\/probe/) | ||
| )).eql(1); |
There was a problem hiding this comment.
NIT: I think L425-436 can be simplified to use:
/randomorgid.authenticatorlocaldev.com:(2000|6512|6513)\/probe/
|
NOTE: PR pending for SIW G3 parity |
|
already merged in another PR #3650 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
httpsDomainin theauthenticatorChalelngeobject for Loopback server bindingdomainfield will store the local host domainPR Checklist
Issue:
Reviewers:
@vakaevich-okta @SohamKolhatkar-okta @shuowu @lesterchoi-okta
Screenshot/Video:
Downstream Monolith Build: