feat: replace app store button for ov enrollment #3671
Conversation
| @@ -1014,6 +1014,19 @@ test | |||
| await t.expect(await enrollOktaVerifyPage.getSameDeviceSetupOnMobileText()).contains(sameDeviceOVEnrollmentInstructions3); | |||
|
|
|||
| await t.expect(await enrollOktaVerifyPage.orAnotherMobileDeviceLinkExists()).eql(true); | |||
|
|
|||
| if (!userVariables.gen3) { | |||
There was a problem hiding this comment.
So it looks like this fix will happen for gen3 later on? Do we have a ticket for that and could we potentially link it here as an inline comment + reminder so this work doesn't slip through the cracks
There was a problem hiding this comment.
no mock has been provided for gen3, so change only apply to gen2 for now, aligned with @lesterchoi-okta
| await t.expect(downloadInstruction).contains('Don’t have Okta Verify?'); | ||
| await t.expect(downloadInstruction).contains('Download here'); |
There was a problem hiding this comment.
Did you separate this into two different .contains() calls because of the  ?
There was a problem hiding this comment.
sort of, tried to assert eql against innerText of the element, not sure what's the cause, by testcafe assets two same string as false, then I followed pattern from
to assert two parts separately| const downloadInstruction = await enrollOktaVerifyPage.getSameDeviceDownloadText(); | ||
| await t.expect(downloadInstruction).contains('Don’t have Okta Verify?'); | ||
| await t.expect(downloadInstruction).contains('Download here'); | ||
| await t.expect(await enrollOktaVerifyPage.appStoreElementExists()).eql(false); |
There was a problem hiding this comment.
This assertion is fine for now to differentiate between gen2 and gen3 UX, but we should make sure to remove it once the app store logo does not exist for both generations since it doesn't feel necessary to assert that an image that we know DNE is no longer there
| {{#if sameDeviceOVEnrollmentEnabled}} | ||
| <li> | ||
| <span>{{i18n code="customUri.required.content.download.title" bundle="login"}}</span> | ||
| <a href="{{deviceMap.downloadHref}}" target="_blank" id="download-ov" class="orOnMobileLink"> |
There was a problem hiding this comment.
Not a big deal, but does the download-ov ID serve any additional purpose besides being used as a selector in the page object? If not, could we just use the orOnMobileLink class as the selector?
There was a problem hiding this comment.
not sure, just following existing pattern of how the link is constructed
oktapp-aperture-okta
bot
deleted the
sw-ov-enrolment-replace-app-store-button-OKTA-744565
branch
Description:
UX change to replace app store button for ov enrolment
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Mobile
Desktop
Downstream Monolith Build: