Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed nowrap to properly wrap text on OV verify w/o QR code screen #3690

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

alexchen-okta
Copy link
Contributor

@alexchen-okta alexchen-okta commented Aug 14, 2024

Description:

This PR fixes the bug where Japanese text fails to wrap properly on the Okta Verify without QR code screen. The issue was with the way spans are being styled, and is not specific to only Japanese text. Removing the nowrap property for span.no-translate fixed this issue.

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

Before:
image

After:
image

Downstream Monolith Build:

package.json Outdated
"version": "7.21.0",
"version": "7.22.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@alexchen-okta alexchen-okta force-pushed the ac-WrapJapaneseText-OKTA-745200 branch 3 times, most recently from 33df8ad to 5e85cb1 Compare August 14, 2024 20:31
@alexchen-okta alexchen-okta force-pushed the ac-WrapJapaneseText-OKTA-745200 branch from 5e85cb1 to 975eb59 Compare August 15, 2024 14:26
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit b774e81 into 7.21 Aug 15, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the ac-WrapJapaneseText-OKTA-745200 branch August 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants