Update OktaLogger pod spec #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemshvydkyi-okta
changed the title
artemshvydkyi-okta
requested review from
moisesolmedo-okta,
sandeeppenchala-okta and
IldarAbdullin-okta
IldarAbdullin-okta
requested changes
Jul 9, 2024
There was a problem hiding this comment.
@sandeeppenchala-okta , @artemshvydkyi-okta , I don't understand the change. What we are fixing?
OktaLogger.podspec
Outdated
| @@ -11,13 +11,14 @@ Pod::Spec.new do |s| | |||
| s.osx.deployment_target = '10.14' | |||
| s.watchos.deployment_target = '6.0' | |||
| s.swift_version = '5.0' | |||
| s.dependency 'SwiftLint' | |||
artemshvydkyi-okta
force-pushed
the
as-OKTA-744348
branch
from
9715606
to
1f2824f
Compare
|
@IldarAbdullin-okta Podspec had incorrect dependencies. Version with incorrect dependencies didn't provide to launch unit tests of the extensions in the main app. |
| @@ -17,7 +17,7 @@ Pod::Spec.new do |s| | |||
| s.subspec "Complete" do |complete| | |||
| complete.dependency 'OktaLogger/FileLogger' | |||
| complete.dependency 'OktaLogger/FirebaseCrashlytics' | |||
| complete.ios.dependency 'OktaLogger/InstabugLogger' | |||
| complete.dependency 'OktaLogger/InstabugLogger' | |||
There was a problem hiding this comment.
do we need this change?, we only support for iOS
There was a problem hiding this comment.
Without this change pod lib lint validation doesn't pass
There was a problem hiding this comment.
This might fail when you integrate in OV, please test it locally. macOS don't have Instabug support
There was a problem hiding this comment.
Double checked and everything is good
artemshvydkyi-okta
requested review from
sandeeppenchala-okta and
IldarAbdullin-okta
sandeeppenchala-okta
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OktaLogger pod spec