-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OktaLogger pod spec #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeeppenchala-okta , @artemshvydkyi-okta , I don't understand the change. What we are fixing?
OktaLogger.podspec
Outdated
@@ -11,13 +11,14 @@ Pod::Spec.new do |s| | |||
s.osx.deployment_target = '10.14' | |||
s.watchos.deployment_target = '6.0' | |||
s.swift_version = '5.0' | |||
s.dependency 'SwiftLint' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
9715606
to
1f2824f
Compare
@IldarAbdullin-okta Podspec had incorrect dependencies. Version with incorrect dependencies didn't provide to launch unit tests of the extensions in the main app. |
@@ -17,7 +17,7 @@ Pod::Spec.new do |s| | |||
s.subspec "Complete" do |complete| | |||
complete.dependency 'OktaLogger/FileLogger' | |||
complete.dependency 'OktaLogger/FirebaseCrashlytics' | |||
complete.ios.dependency 'OktaLogger/InstabugLogger' | |||
complete.dependency 'OktaLogger/InstabugLogger' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this change?, we only support for iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this change pod lib lint
validation doesn't pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might fail when you integrate in OV, please test it locally. macOS don't have Instabug support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked and everything is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update OktaLogger pod spec