-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sudo Commands Bundle #132
Add Sudo Commands Bundle #132
Conversation
@@ -7,7 +7,7 @@ VERSION=0.4.1 | |||
OS_ARCH=$(shell go env GOOS)_$(shell go env GOARCH) | |||
PLUGIN_DIR=~/.terraform.d/plugins | |||
DOCGEN_RESOURCES_DIR=docgen-resources | |||
|
|||
GOPRIVATE="github.com/atko-pam,github.com/okta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the makefile with these or was this locally added to test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this was suggested by Evan to easily update the pam sudo sdk version and other dependencies.
"github.com/okta/terraform-provider-oktapam/oktapam/utils" | ||
) | ||
|
||
func TestAccResourceSudoCommandBundle(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add update test?
Also if not already, can we modify the policy terraform to include adding/updating rules with sudo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed this but approving to see if it is a green checkmark.
It has already been approved by two other people.
Create a new provider for the sudo commands bundle.
Used https://github.com/atko-pam/pam-sdk-go/pull/64 https://github.com/atko-pam/pam-sdk-go/pull/76 to generate the client