Add Sudo Commands Bundle #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ VERSION=0.4.1 | |||
| OS_ARCH=$(shell go env GOOS)_$(shell go env GOARCH) | |||
| PLUGIN_DIR=~/.terraform.d/plugins | |||
| DOCGEN_RESOURCES_DIR=docgen-resources | |||
|
|
|||
| GOPRIVATE="github.com/atko-pam,github.com/okta" | |||
There was a problem hiding this comment.
do we need to update the makefile with these or was this locally added to test?
There was a problem hiding this comment.
No this was suggested by Evan to easily update the pam sudo sdk version and other dependencies.
| "github.com/okta/terraform-provider-oktapam/oktapam/utils" | ||
| ) | ||
|
|
||
| func TestAccResourceSudoCommandBundle(t *testing.T) { |
There was a problem hiding this comment.
can we add update test?
Also if not already, can we modify the policy terraform to include adding/updating rules with sudo.
There was a problem hiding this comment.
Sure I can look into it.
shrirangadgaonkar-okta
approved these changes
Jul 18, 2024
shrirangadgaonkar-okta
approved these changes
Jul 18, 2024
sachinsaxena-okta
approved these changes
Jul 18, 2024
jamesbuchan-okta
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new provider for the sudo commands bundle.
Used https://github.com/atko-pam/pam-sdk-go/pull/64 https://github.com/atko-pam/pam-sdk-go/pull/76 to generate the client