Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(useEscapeKeydown): cleanup test #250

Merged
merged 3 commits into from
Jul 29, 2023
Merged

refactor(useEscapeKeydown): cleanup test #250

merged 3 commits into from
Jul 29, 2023

Conversation

Cr0zy07
Copy link
Collaborator

@Cr0zy07 Cr0zy07 commented Jul 28, 2023

Description

remove duplicated code from useEscapeKeydown test

Linked Issues

refactor #248

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

dammy001
dammy001 reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@dammy001 dammy001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cr0zy07 can you also add a test to confirm that the event is not been called when a component unmount.

@Cr0zy07
Copy link
Collaborator Author

Cr0zy07 commented Jul 28, 2023

@dammy001, Okay, I will do it tonight...

@dammy001 dammy001 merged commit 73300be into oku-ui:main Jul 29, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YeSuX YeSuX YeSuX approved these changes

@dammy001 dammy001 dammy001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cr0zy07 @dammy001 @YeSuX