Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collection): new component collection #262

Merged
merged 6 commits into from
Aug 3, 2023
Merged

feat(collection): new component collection #262

merged 6 commits into from
Aug 3, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Aug 2, 2023 •
edited
Loading

Description

Linked Issues

close #226

Additional context

@productdevbook productdevbook self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.73% 1416 / 1671
🔵 Statements 84.73% 1416 / 1671
🔵 Functions 83.63% 46 / 55
🔵 Branches 79.02% 113 / 143
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/slot/src/slot.ts 94.44% 84.61% 100% 94.44% 39-41
packages/core/provide/src/createProvide.ts 33.82% 75% 40% 33.82% 23-30, 51-106, 108-133
Generated in workflow #507

@productdevbook productdevbook marked this pull request as draft August 2, 2023 20:39
@dammy001
Copy link
Contributor

dammy001 commented Aug 3, 2023

@productdevbook this ready for review?

@productdevbook
Copy link
Member Author

@dammy001 %80

@productdevbook productdevbook marked this pull request as ready for review August 3, 2023 06:04
@productdevbook productdevbook changed the title feat: collection feat(collection): new component collection Aug 3, 2023
@productdevbook productdevbook merged commit 90c6115 into main Aug 3, 2023
6 checks passed
@productdevbook productdevbook deleted the f-collection branch August 3, 2023 08:36
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 Awaiting requested review from dammy001

@YeSuX YeSuX Awaiting requested review from YeSuX

Assignees

@productdevbook productdevbook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collection package
2 participants
@productdevbook @dammy001