Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use-rect package #274

Merged
merged 6 commits into from
Aug 10, 2023
Merged

feat: use-rect package #274

merged 6 commits into from
Aug 10, 2023

Conversation

wramzo
Copy link
Contributor

@wramzo wramzo commented Aug 7, 2023

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thank you for following the naming conventions! 🙏

@dammy001
Copy link
Contributor

dammy001 commented Aug 8, 2023

@ramzzo lock file is not up to date. Can you run pnpm i locally and push again

@productdevbook
Copy link
Member

packages/core/use-composable/src this code should be here. Let's not pack.

@dammy001
Copy link
Contributor

dammy001 commented Aug 8, 2023

packages/core/use-composable/src this code should be here. Let's not pack.

Yeah, true

@productdevbook productdevbook linked an issue Aug 8, 2023 that may be closed by this pull request
@dammy001
Copy link
Contributor

dammy001 commented Aug 8, 2023

@ramzzo can you add minimal test for this?

@wramzo
Copy link
Contributor Author

wramzo commented Aug 8, 2023

Even though I downloaded the oku-ui utils package, I get the error that the oku-ui utils package does not exist. so I can't run the test and see the result. I tried deleting and re-downloading the node_modules and lock file but the situation was the same.

image

image

image

@productdevbook
Copy link
Member

productdevbook commented Aug 9, 2023

pnpm build:all after pnpm test

@dammy001 dammy001 merged commit 298b3ec into oku-ui:main Aug 10, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use-rect package
3 participants