Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collection): add stories #288

Merged
merged 10 commits into from
Aug 20, 2023
Merged

feat(collection): add stories #288

merged 10 commits into from
Aug 20, 2023

Conversation

YeSuX
Copy link
Collaborator

@YeSuX YeSuX commented Aug 19, 2023

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2023

Thank you for following the naming conventions! 🙏

@@ -1,4 +1,4 @@
@tailwind base;
/* @tailwind base; */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we do this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

html default style can be reseted by taiwind base.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I delete the taiwind base

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will take a look at this

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.98% 3020 / 3639
🔵 Statements 82.98% 3020 / 3639
🔵 Functions 69.91% 86 / 123
🔵 Branches 80.99% 196 / 242
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/collection/src/collection.ts 99.35% 100% 100% 99.35% 111
Generated in workflow #617

@productdevbook productdevbook marked this pull request as draft August 19, 2023 11:13
@productdevbook productdevbook marked this pull request as ready for review August 20, 2023 03:49
@productdevbook productdevbook changed the title feat(collection): add stories chore(collection): add stories Aug 20, 2023
@productdevbook productdevbook changed the title chore(collection): add stories feat(collection): add stories Aug 20, 2023
@productdevbook productdevbook merged commit 5e11edf into main Aug 20, 2023
8 checks passed
@productdevbook productdevbook deleted the fix-collection branch August 20, 2023 03:56
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants