Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): new component #312

Merged
merged 16 commits into from
Aug 31, 2023
Merged

feat(tooltip): new component #312

merged 16 commits into from
Aug 31, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Aug 27, 2023

There's a bug in the way it works. This needs to be resolved. If you fix it, send a separate pr and we'll merge it here.

CleanShot.2023-08-27.at.14.01.55.mp4

@productdevbook productdevbook linked an issue Aug 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook changed the title feat(tooltip): new component feat(tooltip): new component - bugs Aug 27, 2023
@productdevbook productdevbook self-assigned this Aug 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.14% 4655 / 5532
🔵 Statements 84.14% 4655 / 5532
🔵 Functions 68.44% 154 / 225
🔵 Branches 81.35% 336 / 413
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/arrow/src/arrow.ts 88.46% 60% 100% 88.46% 46-54
packages/components/dismissable-layer/src/DismissableLayer.ts 45.39% 100% 0% 45.39% 138-309
packages/components/popper/src/popper.ts 95.74% 66.66% 50% 95.74% 38-39
packages/components/portal/src/Portal.ts 98.41% 80% 100% 98.41% 56
packages/components/visually-hidden/src/VisuallyHidden.ts 100% 100% 100% 100%
Generated in workflow #719

@productdevbook productdevbook changed the title feat(tooltip): new component - bugs feat(tooltip): new component Aug 31, 2023
@productdevbook productdevbook marked this pull request as ready for review August 31, 2023 09:28
@productdevbook productdevbook merged commit 209694c into main Aug 31, 2023
6 checks passed
@productdevbook productdevbook deleted the feat-tooltip branch August 31, 2023 09:36
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip
1 participant