Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): new component #325

Merged
merged 18 commits into from
Sep 2, 2023
Merged

feat(slider): new component #325

merged 18 commits into from
Sep 2, 2023

Conversation

productdevbook
Copy link
Member

@productdevbook productdevbook commented Sep 2, 2023

Description

Linked Issues

close #21

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.02% 5053 / 5874
🔵 Statements 86.02% 5053 / 5874
🔵 Functions 72.72% 176 / 242
🔵 Branches 83.33% 385 / 462
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/avatar/src/avatarImage.ts 100% 88.88% 100% 100%
packages/components/collection/src/collection.ts 99.35% 100% 100% 99.35% 112
packages/components/dismissable-layer/src/util.ts 73.05% 87.5% 44.44% 73.05% 44-85, 105-109, 146, 156-159
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 80.44% 81.81% 14.28% 80.44% 84-85, 110-111, 113-114, 119-120, 135, 137, 140, 142-163, 166, 168
packages/components/roving-focus/src/RovingFocusGroupItem.ts 73.56% 87.5% 40% 73.56% 90-92, 112, 114-119, 122, 124, 127, 129-161
packages/core/use-composable/src/useCallbackRef.ts 100% 100% 100% 100%
packages/core/use-composable/src/useEscapeKeydown.ts 100% 83.33% 100% 100%
Generated in workflow #750

@productdevbook
Copy link
Member Author

cc: @Mushrr, You wrote a test for the slider. I think you can rewrite it. We have completed the slider. You can also take a look at the codes.

@productdevbook productdevbook merged commit 7e8c282 into main Sep 2, 2023
6 checks passed
@productdevbook productdevbook deleted the feat-slider branch September 2, 2023 03:51
@github-actions github-actions bot mentioned this pull request Sep 2, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider
2 participants