Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: all component style and some minor fix bugs #330

Merged
merged 8 commits into from
Sep 3, 2023

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.05% 5052 / 5871
🔵 Statements 86.05% 5052 / 5871
🔵 Functions 72.72% 176 / 242
🔵 Branches 83.51% 385 / 461
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/arrow/src/arrow.ts 88.88% 60% 100% 88.88% 49-57
packages/components/arrow/src/index.ts 100% 100% 100% 100%
packages/components/aspect-ratio/src/aspect-ratio.ts 100% 75% 100% 100%
packages/components/aspect-ratio/src/index.ts 100% 100% 100% 100%
packages/components/avatar/src/avatar.ts 100% 100% 100% 100%
packages/components/avatar/src/avatarFallback.ts 100% 100% 100% 100%
packages/components/avatar/src/avatarImage.ts 100% 88.88% 100% 100%
packages/components/avatar/src/index.ts 100% 100% 100% 100%
packages/components/checkbox/src/bubbleInput.ts 56.32% 100% 0% 56.32% 44-81
packages/components/checkbox/src/checkbox.ts 86.52% 78.57% 72.72% 86.52% 128, 150-153, 176, 178-180, 188-194, 201-215
packages/components/checkbox/src/checkboxIndicator.ts 100% 75% 100% 100%
packages/components/collapsible/src/collapsible.ts 99.24% 94.73% 88.88% 99.24% 89
packages/components/collapsible/src/collapsibleContent.ts 77.77% 100% 50% 77.77% 61-80
packages/components/collapsible/src/collapsibleContentImpl.ts 61.15% 50% 50% 61.15% 56, 60, 64-87, 91-111
packages/components/collapsible/src/collapsibleTrigger.ts 100% 88.88% 100% 100%
packages/components/collapsible/src/index.ts 100% 100% 100% 100%
packages/components/dismissable-layer/src/DismissableLayer.ts 45.07% 100% 0% 45.07% 137-309
packages/components/focus-scope/src/focus-scope.ts 94.82% 64.1% 81.81% 94.82% 126, 157-164, 214, 226, 238-239, 269-271
packages/components/label/src/label.ts 89.13% 100% 75% 89.13% 29-33
packages/components/portal/src/Portal.ts 98.41% 80% 100% 98.41% 56
packages/components/radio-group/src/BubbleInput.ts 56.79% 100% 0% 56.79% 41-75
packages/components/radio-group/src/Radio.ts 86.25% 78.57% 100% 86.25% 126-133, 139-152
packages/components/radio-group/src/RadioGroup.ts 99.45% 85.71% 88.88% 99.45% 132
packages/components/radio-group/src/RadioGroupIndicator.ts 100% 100% 100% 100%
packages/components/radio-group/src/RadioGroupItem.ts 83.82% 100% 50% 83.82% 69-71, 73-74, 82-83, 106-108, 111-112, 114-123
packages/components/radio-group/src/RadioIndicator.ts 100% 83.33% 100% 100%
packages/components/radio-group/src/index.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 80.44% 81.81% 14.28% 80.44% 84-85, 110-111, 113-114, 119-120, 135, 137, 140, 142-163, 166, 168
packages/components/roving-focus/src/RovingFocusGroupItem.ts 73.41% 87.5% 40% 73.41% 89-91, 111, 113-118, 121, 123, 126, 128-160
packages/components/roving-focus/src/index.ts 100% 100% 100% 100%
packages/components/separator/src/separator.ts 100% 91.66% 100% 100%
packages/components/switch/src/BubbleInput.ts 95.83% 60% 100% 95.83% 65-68
packages/components/switch/src/Switch.ts 98.2% 85% 88.88% 98.2% 130-132, 144
packages/components/switch/src/SwitchThumb.ts 61.01% 100% 0% 61.01% 31-53
packages/components/switch/src/index.ts 100% 100% 100% 100%
packages/components/toggle/src/toggle.ts 98.52% 85.71% 88.88% 98.52% 87, 90
packages/components/visually-hidden/src/VisuallyHidden.ts 100% 100% 100% 100%
packages/core/focus-guards/src/utils.ts 100% 100% 100% 100%
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/primitive.ts 100% 100% 100% 100%
packages/core/primitive/src/types.ts 99.35% 100% 0% 99.35% 116-117
Generated in workflow #768

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.05% 5052 / 5871
🔵 Statements 86.05% 5052 / 5871
🔵 Functions 72.72% 176 / 242
🔵 Branches 83.51% 385 / 461
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/arrow/src/arrow.ts 88.88% 60% 100% 88.88% 49-57
packages/components/arrow/src/index.ts 100% 100% 100% 100%
packages/components/aspect-ratio/src/aspect-ratio.ts 100% 75% 100% 100%
packages/components/aspect-ratio/src/index.ts 100% 100% 100% 100%
packages/components/avatar/src/avatar.ts 100% 100% 100% 100%
packages/components/avatar/src/avatarFallback.ts 100% 100% 100% 100%
packages/components/avatar/src/avatarImage.ts 100% 88.88% 100% 100%
packages/components/avatar/src/index.ts 100% 100% 100% 100%
packages/components/checkbox/src/bubbleInput.ts 56.32% 100% 0% 56.32% 44-81
packages/components/checkbox/src/checkbox.ts 86.52% 78.57% 72.72% 86.52% 128, 150-153, 176, 178-180, 188-194, 201-215
packages/components/checkbox/src/checkboxIndicator.ts 100% 75% 100% 100%
packages/components/collapsible/src/collapsible.ts 99.24% 94.73% 88.88% 99.24% 89
packages/components/collapsible/src/collapsibleContent.ts 77.77% 100% 50% 77.77% 61-80
packages/components/collapsible/src/collapsibleContentImpl.ts 61.15% 50% 50% 61.15% 56, 60, 64-87, 91-111
packages/components/collapsible/src/collapsibleTrigger.ts 100% 88.88% 100% 100%
packages/components/collapsible/src/index.ts 100% 100% 100% 100%
packages/components/dismissable-layer/src/DismissableLayer.ts 45.07% 100% 0% 45.07% 137-309
packages/components/focus-scope/src/focus-scope.ts 94.82% 64.1% 81.81% 94.82% 126, 157-164, 214, 226, 238-239, 269-271
packages/components/label/src/label.ts 89.13% 100% 75% 89.13% 29-33
packages/components/portal/src/Portal.ts 98.41% 80% 100% 98.41% 56
packages/components/radio-group/src/BubbleInput.ts 56.79% 100% 0% 56.79% 41-75
packages/components/radio-group/src/Radio.ts 86.25% 78.57% 100% 86.25% 126-133, 139-152
packages/components/radio-group/src/RadioGroup.ts 99.45% 85.71% 88.88% 99.45% 132
packages/components/radio-group/src/RadioGroupIndicator.ts 100% 100% 100% 100%
packages/components/radio-group/src/RadioGroupItem.ts 83.82% 100% 50% 83.82% 69-71, 73-74, 82-83, 106-108, 111-112, 114-123
packages/components/radio-group/src/RadioIndicator.ts 100% 83.33% 100% 100%
packages/components/radio-group/src/index.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 80.44% 81.81% 14.28% 80.44% 84-85, 110-111, 113-114, 119-120, 135, 137, 140, 142-163, 166, 168
packages/components/roving-focus/src/RovingFocusGroupItem.ts 73.41% 87.5% 40% 73.41% 89-91, 111, 113-118, 121, 123, 126, 128-160
packages/components/roving-focus/src/index.ts 100% 100% 100% 100%
packages/components/separator/src/separator.ts 100% 91.66% 100% 100%
packages/components/switch/src/BubbleInput.ts 95.83% 60% 100% 95.83% 65-68
packages/components/switch/src/Switch.ts 98.2% 85% 88.88% 98.2% 130-132, 144
packages/components/switch/src/SwitchThumb.ts 61.01% 100% 0% 61.01% 31-53
packages/components/switch/src/index.ts 100% 100% 100% 100%
packages/components/toggle/src/toggle.ts 98.52% 85.71% 88.88% 98.52% 87, 90
packages/components/visually-hidden/src/VisuallyHidden.ts 100% 100% 100% 100%
packages/core/focus-guards/src/utils.ts 100% 100% 100% 100%
packages/core/primitive/src/index.ts 100% 100% 100% 100%
packages/core/primitive/src/primitive.ts 100% 100% 100% 100%
packages/core/primitive/src/types.ts 99.35% 100% 0% 99.35% 116-117
Generated in workflow #768

@productdevbook productdevbook merged commit 3a919d2 into main Sep 3, 2023
6 checks passed
@productdevbook productdevbook deleted the fix-style branch September 3, 2023 06:21
@github-actions github-actions bot mentioned this pull request Sep 3, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant