refactor(accordion): accordion and collasiple ts to sfc #531
Conversation
|
Thank you for following the naming conventions! 🙏 |
productdevbook
changed the title
productdevbook
changed the title
|
It's great to see a pr like this, can you get a pr draft if it's not finished? Thank you very, very much. ❤️ |
There was a problem hiding this comment.
'./usePresence.js' -> './usePresence' no need to type js. The compiler will take care of them.
There was a problem hiding this comment.
| @@ -38,7 +38,7 @@ function createScope<T extends string>(scopeName: T, createScopeDeps: CreateScop | |||
| * --------------------------------------------------------------------------------------------- */ | |||
|
|
|||
| function createProvide<ProvideValueType extends object | null>( | |||
| rootComponentName: T, | |||
| rootComponentName: string, | |||
There was a problem hiding this comment.
why change string T -> string ?
productdevbook
changed the title
|
I absolutely cannot understand how it works and why it might be useful. Context Scopes |
Плохо понимаю ( |
|
#492 most of the components are broken. They work in storybook. Can you check them? Somewhere there have been fractures. maybe I can send some commits when I have more time. |
Я собирался продолжить работу по переносу компонентов на sfc. Большинство компонентов не работают, потому что они импортируют объект props, которого больше нет. Сейчас это interface |
|
Those with SFC transitions will work. Try not to break other components when creating PR. Also the storybook does not work in accordion. |
the last commit that was built without errors was with the tag 0.6.2. |
|
#492 those who have completed the sfc migration here are the ones whose storybook is fully operational. You can check here. |
|
you made the accordion move sfc in this pr, but the storybook doesn't work at all. You've got destructive changes all over the place. Did you check the storybook accordion while making them? |
corrected the storybook |
|
I am currently doing |
|
LGTM! Thank you for your wonderful work. ❤️ |
Description
Linked Issues
cc: #492
Additional context