Skip to content

Commit

Permalink
do not call [super loadView] in RN's UIViewController (facebook#45312)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#45312

changelog: [internal]

loadview shouldn't call its super method. Even though it isn't broken now, the official docs recommend against it.

https://developer.apple.com/documentation/uikit/uiviewcontroller/1621454-loadview

Reviewed By: christophpurrer

Differential Revision: D59376105

fbshipit-source-id: ee04020c008a3f208aafc79991c6ff24a71b226f
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Jul 8, 2024
1 parent 258f41a commit 83392a9
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ - (void)viewDidLayoutSubviews

- (void)loadView
{
[super loadView];
self.view = [UIView new];
[_touchHandler attachToView:self.view];
}

Expand Down

0 comments on commit 83392a9

Please sign in to comment.