Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use value copy instead of pointer copy in stateObject.deepCopy #580

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

summerpro
Copy link
Contributor

@summerpro summerpro commented Jan 22, 2021

From:cosmos/ethermint#741

Close: cosmos/ethermint#740

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #580 (4139022) into dev (c8e9201) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #580      +/-   ##
==========================================
- Coverage   66.56%   66.55%   -0.01%     
==========================================
  Files         306      306              
  Lines       19038    19045       +7     
==========================================
+ Hits        12672    12675       +3     
- Misses       5641     5643       +2     
- Partials      725      727       +2     
Impacted Files Coverage Δ
x/evm/types/state_object.go 81.43% <50.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e9201...4139022. Read the comment docs.

@zhongqiuwood zhongqiuwood merged commit 709ccc2 into dev Jan 23, 2021
@zhongqiuwood zhongqiuwood deleted the ray/deepCopy branch January 23, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "deepCopy" function from "StateObject" makes pointer copy instead of value copy
4 participants