Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Footer Widgets xy grid stacking medium/small #1251

Closed
squidzink opened this issue Mar 16, 2018 · 5 comments
Closed

Footer Widgets xy grid stacking medium/small #1251

squidzink opened this issue Mar 16, 2018 · 5 comments

Comments

@squidzink
Copy link

Even though there were changes made to how footer widgets should respond on medium and small breakpoints, I'm still not seeing the solution to the issue that was presented in #1180 and seemingly resolved in #1189.

What am I missing? Foot widgets still do not expand as expected at medium and small breakpoints even when classes are manually put into widget-areas.php

@JPOak
Copy link
Contributor

JPOak commented Mar 22, 2018

@squidzink The footer works as expected I believe. It's pretty basic and left to the developer to do what they want with it. I never use it as is and normally add in different widget areas.

However, if you just want to add in different breakpoints etc. You can try the below and tweak what you want in _footer.scss

  section {
    @include xy-cell();

    @include breakpoint(large) {
      @include xy-cell(6); //or however you want them to look on large screens
    }

@JPOak
Copy link
Contributor

JPOak commented Mar 22, 2018

@colin-marshall I wonder if we should add a default breakpoint to help clear up confusion with footer widgets on mobile.

Maybe something like:

  section {
    @include xy-cell();
    @include breakpoint(large) {
      @include xy-cell(auto);
    }

@squidzink
Copy link
Author

@JPOak Thanks for the clarification. I'm still catching up on the xy grid. I'm good to go.

@colin-marshall
Copy link
Collaborator

@JPOak ya we forgot about that.

@squidzink
Copy link
Author

Should I go ahead and close this one?

olefredrik added a commit that referenced this issue Apr 1, 2018
Add default breakpoint for smaller screen sizes to footer widget area. #1251
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants