This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Remove wp versions filter to support cdn caching #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDNs use version numbers to deliver new assets. When version number does not exist, the asset is treated as the same and therefore must be flushed. Flushing can be an issue because it creates greater responsibility in having to manage clearing assets. It would be far easier for us to use verion number as default to offer support to CDNs A starting theme should not make the assumption that versioning of assets is not needed.
olefredrik
added a commit
that referenced
this pull request
Dec 8, 2015
Remove wp versions filter to support cdn caching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDNs use version numbers to deliver new assets. When version number does not
exist, the asset is treated as the same and therefore must be flushed. Flushing
can be an issue because it creates greater responsibility in having to manage
clearing assets. It would be far easier for us to use version as default
to offer support to CDNs
A starting theme should not make the assumption that the version of assets is not
needed.