-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wiring diagrams, datasheet and comments on code #18
base: master
Are you sure you want to change the base?
Conversation
Hey, I am maintaining the PZEM004T-v30 library https://github.com/mandulaj/PZEM-004T-v30 which is very similar in terms of the hardware. I have many users being confused about the wiring. Would you mind adding your drawing also there so that the confusion can be resolved for once. Thank you |
Hi,
I have pushed the diagram many years back on my branch and a pr.
Which I got 0 reply to merge to master. That would help wiring diagram for
resolve Confusion
Thnks
…On Sat, Jan 15, 2022, 01:01 Jakub Mandula ***@***.***> wrote:
Hey, I am maintaining the PZEM004T-v30 library
https://github.com/mandulaj/PZEM-004T-v30 which is very similar in terms
of the hardware. I have many users being confused about the wiring. Would
you mind adding your drawing also there so that the confusion can be
resolved for once. Thank you
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMDKQ4VHQVTGGMZ2ODNN4TUWC2MLANCNFSM4DM342KA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Yeah so would you like to add it to my library instead. I am not going to ignore the pull request 😉 |
Hi. I'm sorry, I completely forgot about this request. The reason I didn't accept it at the first place was that it not only adds datasheets as stated in the title, but also modifies example's workflow. Also I doubt I can accept example's changes without further discussion. With these changes, when AC power is off, there will be last positive reading in the freezed log. This can be confusing. |
Hello @olehs, @mandulaj, |
When I originally wrote my version of the library this was my goal. Just haven't had the time to sit down and collect all the pieces. If you have time and motivation then you are welcome to take the initiative 😇 |
Time is the most precious resource for all of us :) OK, I may come up with a list of "useful links" next time. |
Added Datasheet of PZEM004T
Added Wiring diagram
Added comments for RX, TX on Arduino