Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapters): fix gemini respect system prompt removed #529

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

bassamsdata
Copy link
Contributor

Description

gemini doesn't respect gs to remove system prompt and therefore it produces an error.

Related Issue(s)

fix: #528

Checklist

  • I've read the CONTRIBUTING guidelines and have adhered to them in this PR
  • I've updated the README and ran the make docs command

@olimorris olimorris merged commit 7ca4364 into olimorris:main Dec 12, 2024
3 checks passed
@olimorris
Copy link
Owner

Thanks for spotting this, PR'ing it and adding some test coverage. Really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gemini adapter error when removing the system prompt
2 participants