Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(command): use artisan test if Laravel project #8

Closed
wants to merge 1 commit into from

Conversation

saifulapm
Copy link

In addition to the phpunit command, we ca use the test Artisan command to run your tests for Laravel. The Artisan test runner provides verbose test reports in order to ease development and debugging

@olimorris
Copy link
Owner

Appreciate this and thanks for the PR.

One thought I have, would it be easier to allow someone to define this in their own Neotest config rather than bake it into the plugin?

@olimorris
Copy link
Owner

Hey @saifulapm. Your PR inspired me to add configuration option for the phpunit executable (ca4724c).

I'm keen to not bake too much opinionated logic into the adapter so would prefer users to configure it for themselves. Your brilliant PR could hopefully live in your Neotest config.

What do you think?

@saifulapm
Copy link
Author

Yes. That will be great if it's configurable. I was just testing artisan test because artisan output more nice. Thank you

@olimorris
Copy link
Owner

Please play around and let me know how it works. I've documented it in the readme too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants