Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge Clippy error fixes and empty orders validation diffs #64

Merged
merged 4 commits into from
Nov 6, 2023
Merged

merge Clippy error fixes and empty orders validation diffs #64

merged 4 commits into from
Nov 6, 2023

Conversation

m-yahya
Copy link
Member

@m-yahya m-yahya commented Oct 30, 2023

This PR will merge the diffs between the master and my/return-error branches.

@m-yahya m-yahya requested a review from clangenb October 30, 2023 08:46
clangenb
clangenb reviewed Oct 30, 2023
View reviewed changes
.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
.github/workflows/publish-docker-sidechain.yml Outdated Show resolved Hide resolved
core/parentchain/block-importer/src/block_importer.rs Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/docker-compose.yml Outdated Show resolved Hide resolved
return_error_diff.patch Outdated Show resolved Hide resolved
clangenb
clangenb approved these changes Nov 6, 2023
View reviewed changes
Copy link

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would give the PR a meaningful name. ;)

@m-yahya m-yahya changed the title add diffs merge Clippy error fixes and empty orders validation diffs Nov 6, 2023
@m-yahya m-yahya merged commit da4150e into master Nov 6, 2023
18 checks passed
@m-yahya m-yahya deleted the merge_diff_branch branch November 6, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-yahya @clangenb