log better msg

olivercodes · Jun 9, 2021 · 60da891 · 60da891
1 parent d3a06a0
commit 60da891
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -32,7 +32,7 @@ function getApprovers(owners) {
 function getUsersOfAlias(ownersAliases, alias) {
   if (!ownersAliases.aliases) {
     throw new Error('no aliases');
-  }
+  } // TODO - return error if alias does not exist
   return ownersAliases.aliases[alias];
 }
 
@@ -10317,7 +10317,7 @@ try {
   const actor = github.context.actor;
   const isApprover = getUserIsApprover(actor, '.');
   if (!isApprover) {
-    core.setFailed('user is not an approver')
+    core.setFailed(`${actor} is not an approver. Please check your OWNERS file.`)
   } else {
     return true;
   }

diff --git a/index.js b/index.js
@@ -6,7 +6,7 @@ try {
   const actor = github.context.actor;
   const isApprover = getUserIsApprover(actor, '.');
   if (!isApprover) {
-    core.setFailed('user is not an approver')
+    core.setFailed(`${actor} is not an approver. Please check your OWNERS file.`)
   } else {
     return true;
   }

diff --git a/lib/helpers.js b/lib/helpers.js
@@ -26,7 +26,7 @@ function getApprovers(owners) {
 function getUsersOfAlias(ownersAliases, alias) {
   if (!ownersAliases.aliases) {
     throw new Error('no aliases');
-  }
+  } // TODO - return error if alias does not exist
   return ownersAliases.aliases[alias];
 }