fix: messy promises, TODO - more err handling cleanup

olivercodes · Aug 11, 2022 · e60bc2e · e60bc2e
1 parent d03014a
commit e60bc2e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -5,6 +5,7 @@
 /***/ ((module, __unused_webpack_exports, __nccwpck_require__) => {
 
 const {Octokit} = __nccwpck_require__(1231)
+const core = __nccwpck_require__(2186);
 const octokit = new Octokit();
 
 function uniq(a) {
@@ -34,14 +35,17 @@ async function getRepoTeams(org, repo) {
   return Promise.resolve(data
     .filter(team => teamHasWrite(team.permission))
     .map(team => team.name)
-  );
+  ).catch(err => { core.setFailed(err) });
 }
 
 async function getUserIsApprover(org, repo, user) {
   const repoTeams = await getRepoTeams(org, repo);
   teamsArrays = await Promise.all(
     repoTeams.map(team => getTeamUsers(team))
-  );
+  ).catch((err) => {
+    console.error(err)
+    core.setFailed(err);
+  });
 
   const allApprovingUsers = teamsArrays
     .reduce((acc, arr) => acc.concat(arr));

diff --git a/lib/helpers.js b/lib/helpers.js
@@ -1,4 +1,5 @@
 const {Octokit} = require('@octokit/action')
+const core = require('@actions/core');
 const octokit = new Octokit();
 
 function uniq(a) {
@@ -28,14 +29,17 @@ async function getRepoTeams(org, repo) {
   return Promise.resolve(data
     .filter(team => teamHasWrite(team.permission))
     .map(team => team.name)
-  );
+  ).catch(err => { core.setFailed(err) });
 }
 
 async function getUserIsApprover(org, repo, user) {
   const repoTeams = await getRepoTeams(org, repo);
   teamsArrays = await Promise.all(
     repoTeams.map(team => getTeamUsers(team))
-  );
+  ).catch((err) => {
+    console.error(err)
+    core.setFailed(err);
+  });
 
   const allApprovingUsers = teamsArrays
     .reduce((acc, arr) => acc.concat(arr));