Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Arabic translation (1.0.0) #444

Merged
merged 12 commits into from
Mar 5, 2023
Merged

Conversation

RIYADHABBES
Copy link
Contributor

Hello Olivier,

I hope you're doing fine.

I found your changelog website while navigating on the net.
I didn't find Arabic language and since your project is open for contribution, I thought to add the corresponding translation.
Also, I haven't Arabic native speakers in my network so I couldn't add some reviewers.

My thanks to you and all the contributors
best wishes

@olivierlacan
Copy link
Owner

Hi @RIYADHABBES, thank you so much for working on this! I'll ask on Mastodon if some Arabic speakers could review this before we merge.

I really appreciate your effort! 😃

Copy link

@m-soli m-soli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the similar style changes like the ones on the farsi version to align content right and force period at end of sentences to the left.

%p

استخدام تضمينات
%br Git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
%br Git
Git

Copy link

@m-soli m-soli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimming through translations are accurate, styling the page to account for right to left reading of arabic and general readability is my only suggestion.

@olivierlacan
Copy link
Owner

@m-soli I believe we can do that with CSS and text-direction, right?

@RIYADHABBES
Copy link
Contributor Author

RIYADHABBES commented Feb 16, 2023

Hi Olivier,
Hi Mark @m-soli , thank you for taking the time to review my translation,

That's true I had some trouble with mixing both Arabic and English.

I will search if there is a way in CSS or Haml or the Farsi translation to correct the style.

Thank you again

@olivierlacan
Copy link
Owner

olivierlacan commented Feb 16, 2023

@RIYADHABBES This is all you should need:

<style>
body,html,h1,h2,h3,h4,h5,h6,a{font-family:Vazir;direction:rtl;text-align:right}
div.frequently-asked-questions h4:after{float:left}
pre {direction:ltr;text-align:left}
</style>

Thanks again for your contribution! 😃

@RIYADHABBES
Copy link
Contributor Author

Hello Olivier,
Hello Mark,

That's correct I added those lines from the Farsi Translation and it did work just like magic.
Now the text is much more readable and in a better format.
Thanks for your suggestions.

@olivierlacan
Copy link
Owner

@RIYADHABBES I'm going to merge this since despite my calls for review I've had no one offer to review this but if you can find someone to review your translation (just to be safe and catch any accidental mistakes if there are any) that would be a good idea.

Regardless thank you so much for your contributions, I bet this is going to help lot of folks. 😃

@olivierlacan olivierlacan merged commit 53f0205 into olivierlacan:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants