-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Arabic translation (1.0.0) #444
Conversation
Format the text for better mixing arabic alphabet with english alphabet (just add break line where languages are mixed in the same sentence)
Hi @RIYADHABBES, thank you so much for working on this! I'll ask on Mastodon if some Arabic speakers could review this before we merge. I really appreciate your effort! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use the similar style changes like the ones on the farsi version to align content right and force period at end of sentences to the left.
source/ar/1.0.0/index.html.haml
Outdated
%p | ||
|
||
استخدام تضمينات | ||
%br Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%br Git | |
Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimming through translations are accurate, styling the page to account for right to left reading of arabic and general readability is my only suggestion.
@m-soli I believe we can do that with CSS and text-direction, right? |
Hi Olivier, That's true I had some trouble with mixing both Arabic and English. I will search if there is a way in CSS or Haml or the Farsi translation to correct the style. Thank you again |
@RIYADHABBES This is all you should need: keep-a-changelog/source/fa-IR/1.0.0/index.html.haml Lines 22 to 26 in 3aad681
Thanks again for your contribution! 😃 |
Hello Olivier, That's correct I added those lines from the Farsi Translation and it did work just like magic. |
@RIYADHABBES I'm going to merge this since despite my calls for review I've had no one offer to review this but if you can find someone to review your translation (just to be safe and catch any accidental mistakes if there are any) that would be a good idea. Regardless thank you so much for your contributions, I bet this is going to help lot of folks. 😃 |
Hello Olivier,
I hope you're doing fine.
I found your changelog website while navigating on the net.
I didn't find Arabic language and since your project is open for contribution, I thought to add the corresponding translation.
Also, I haven't Arabic native speakers in my network so I couldn't add some reviewers.
My thanks to you and all the contributors
best wishes