Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build:umd command using rollup #455

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

dhleong
Copy link
Contributor

@dhleong dhleong commented Aug 16, 2018

See #454

I decided to sit down and roll my sleeves up and came up with a solution. Not sure how you feel about having rollup, but it's only used for the umd build (seems to be what the other project I mentioned did).

Thanks for your time!

@dhleong
Copy link
Contributor Author

dhleong commented Aug 19, 2018

@oliviertassinari it looks like the unit tests are failing due to circle CI's caching being disabled for some reason, but they did pass on the first build. I just changed the exported library name for the packaged UMD to the more canonical SwipeableViews. I've run the tests locally and they seem to still pass.

@dhleong
Copy link
Contributor Author

dhleong commented Sep 2, 2018

@oliviertassinari I've rebased against master and updated the rollup config for the release version of babel 7

@vanhoutenbos
Copy link
Collaborator

Hi,

Could you resolve the conflicting files for me? I will than test this in a branch and see if I can accept the PR :)

@dhleong
Copy link
Contributor Author

dhleong commented Dec 4, 2019

Rebased but haven't checked for outdated dependencies or anything; I've switched to a different build tool for my project that can consume this library directly from NPM, so I don't have a place to test this PR anymore.

@vanhoutenbos
Copy link
Collaborator

I will take the time to test this PR tonight, thank you for the rebase!

@vanhoutenbos vanhoutenbos merged commit a02f5f1 into oliviertassinari:master Dec 11, 2019
@vanhoutenbos
Copy link
Collaborator

Took a bit longer than expected to test, This looks good!

chilliams pushed a commit to chilliams/react-swipeable-views that referenced this pull request Mar 20, 2020
* Add build:umd command using rollup

See oliviertassinari#454

* Update rollup config for babel 7 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants