-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build:umd command using rollup #455
Conversation
@oliviertassinari it looks like the unit tests are failing due to circle CI's caching being disabled for some reason, but they did pass on the first build. I just changed the exported library name for the packaged UMD to the more canonical |
@oliviertassinari I've rebased against master and updated the rollup config for the release version of babel 7 |
6dc158b
to
01b6f62
Compare
Hi, Could you resolve the conflicting files for me? I will than test this in a branch and see if I can accept the PR :) |
Rebased but haven't checked for outdated dependencies or anything; I've switched to a different build tool for my project that can consume this library directly from NPM, so I don't have a place to test this PR anymore. |
I will take the time to test this PR tonight, thank you for the rebase! |
Took a bit longer than expected to test, This looks good! |
* Add build:umd command using rollup See oliviertassinari#454 * Update rollup config for babel 7 release
See #454
I decided to sit down and roll my sleeves up and came up with a solution. Not sure how you feel about having rollup, but it's only used for the umd build (seems to be what the other project I mentioned did).
Thanks for your time!