-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbortableAsyncIterator type export #135
Comments
I believe it's import type { AbortableAsyncIterator } from "ollama/utils"; Although generally "utils" things are for internal use, so it might be worth moving it to |
|
Hm, I thought this line in the Line 19 in c03ea59
Regardless, it probably makes more sense to define AbortableAsyncIterator in index.ts instead of utils.ts . I'd like another maintainers opinion on this first, though, in case it's better suited in an entirely different file.
Thanks for bringing this to our attention! |
I can confirm this is an issue as well. It seems clear that the intent was to export |
This is still an error for me, would be very useful to export the type if possible! Thanks! |
Since it doesn't look like I'm getting a maintainer's approval any time soon, I'll just create a PR now and see if it gets accepted |
We've given it some thought and think it is best if stream management is done by the user. We'll move forward with 1 client per stream at the moment. I've updated the examples in here - would also love your thoughts 😄 |
Hi,
It seems there is no type export for
AbortableAsyncIterator
class.When I import:
It gives me a type error:
The text was updated successfully, but these errors were encountered: