Custom Headers #158
Merged
Custom Headers #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Naveen <78990165+gnpaone@users.noreply.github.com>
ParthSareen
commented
Nov 7, 2024
|
|
||
| if (!options.headers) { | ||
| options.headers = {} | ||
| } | ||
|
|
||
| // Filter out default headers from custom headers | ||
| const customHeaders = Object.fromEntries( |
There was a problem hiding this comment.
Bringing to parity with python sdk impl. For ref: ollama/ollama-python#313
BruceMacD
approved these changes
Nov 7, 2024
BruceMacD
approved these changes
Nov 7, 2024
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeadersInitinstead ofHeaders-> more flexible classChecked functionality by adding logging middleware on go server locally.
Also ran some quick tests:
Closes #154
Closes #156
Shoutout to @gnpaone for getting it most of the way there!