fix: issue 89 - correct base64 encoding for Uint8Array in encodeImage function #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the encodeImage function to fix a bug where large Uint8Arrays could cause a RangeError due to exceeding the maximum argument length of String.fromCharCode.apply. The new implementation iterates through the Uint8Array and builds the binary string manually, ensuring proper conversion for arrays of any size.
BruceMacD
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 89
Refactor the encodeImage function to fix a bug where large Uint8Arrays could cause a RangeError due to exceeding the maximum argument length of String.fromCharCode.apply. The new implementation iterates through the Uint8Array and builds the binary string manually, ensuring proper conversion for arrays of any size.