JavaScript API PS #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
reviewed
Jun 4, 2024
README.md
Outdated
| ### process | ||
|
|
||
| ```javascript | ||
| ollama.process() |
There was a problem hiding this comment.
Suggested change
| ollama.process() | |
| ollama.ps() |
jmorganca
reviewed
Jun 4, 2024
README.md
Outdated
| @@ -187,6 +187,14 @@ ollama.embeddings(request) | |||
| - `options` `<Options>`: (Optional) Options to configure the runtime. | |||
| - Returns: `<EmbeddingsResponse>` | |||
|
|
|||
| ### process | |||
There was a problem hiding this comment.
Suggested change
| ### process | |
| ### ps |
Ideally we describe this a bit but to keep it consistent
|
I agree that the function should be named consistently with existing functions, but I personally don't think functions should need to be named the same as the API endpoint because surely the purpose of this library is to abstract away from the API. Obviously, though, this would be a breaking change, so it would either need to be a major change or act as aliases (perhaps with old ones being deprecated). |
BruceMacD
reviewed
Jun 5, 2024
examples/list/list.ts
Outdated
| @@ -0,0 +1,16 @@ | |||
| import ollama from '../../src/browser' | |||
There was a problem hiding this comment.
let's omit this example for now
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.