make subscription methods more consistent with __contains__
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
changed the title
jmorganca
changed the title
__contains__
jmorganca
commented
Nov 24, 2024
jmorganca
requested review from
ParthSareen
and removed request for
ParthSareen
ParthSareen
reviewed
Nov 26, 2024
Co-authored-by: Parth Sareen <parth.sareen@ollama.com>
ParthSareen
reviewed
Nov 26, 2024
ParthSareen
reviewed
Nov 26, 2024
ParthSareen
reviewed
Nov 26, 2024
Co-authored-by: Parth Sareen <parth.sareen@ollama.com>
Co-authored-by: Parth Sareen <parth.sareen@ollama.com>
Co-authored-by: Parth Sareen <parth.sareen@ollama.com>
|
Ran examples as well - looks good! |
ParthSareen
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message["tool_calls"]will now raise an exception if it's not set to be consistent with the old map behavior and the__contains__operation updated in 0.4.1