fix: ensure Image objects can be used directly #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Could also be related to #375 - will check this out |
|
Hi @akx - should fix some interface mismatch stuff here too so going to work off your PR :) Thanks for your contribution 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix in the 2nd commit,
_copy_messages()would raise a Pydantic error asImages are being wrapped asImage(value=Image(...)).Related to #384 which exposes the model for general use.
This PR also removes Pillow from testing dependencies; it's not worth it to pull in a dependency just to generate a static 1x1 PNG we already know.