-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration time attributes format #257
Comments
This would be a breaking change because all automations and cards are based on current format, so I prefer to avoid this. Platform template is the right solution to format time values as you need. |
I'm not a big fan of sensor duplication with template platform, but I can understand your opinion regarding the regression. In any case, reading this page https://www.home-assistant.io/integrations/timer/ , I think that the default way to express a duration in HA is with 00:00:00 format. |
I can update the card if needed. |
Ok, I will think a little bit more about this. Using standard format is better, I'm just worried about the coming issue due to the breaking change. |
You've done breaking changes in the past. It should be okay. |
Just committed this change in can you please create a PR to update the card so that I will create a new release with both changes? Thanks. |
Actually, just from glancing at the card's code, it should work fine. Can someone else test the card (my integration is broken ATM)? |
Installed the card with the updated integration and it seems to work out of the box. |
Yesterday with the updated integration and card active the dryer suddenly stopped the program. I don't think it is related, but better testing. |
Before I update, what exactly is breaking in this update? The changelog says, there are breaking changes... |
The format of attributes / sensors |
ok, thank you. that should not affect my setup, i think... we will see. going to give it a shot now ;-) |
I close this FR, feature now is implemented and released. If there are some problem with feature please open a new issue describing details. |
Is it possible to format duration time attributes by adding the seconds at the end of the timetag as ":00"? This will make this integration compatible with timer bar card used to display a progress bar with remaining times. See rianadon/timer-bar-card#15
As a workaround currently it is required to define custom template sensors by manually adding the seconds.
Thanks.
The text was updated successfully, but these errors were encountered: