Exposes core private functionality in data layer, while annotating with

@VisibleForTesting
olmps · Mar 29, 2021 · af6189d · af6189d
1 parent b122aeb
commit af6189d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/data/database_repository.dart b/lib/data/database_repository.dart
@@ -1,6 +1,7 @@
 import 'dart:async';
 
 import 'package:equatable/equatable.dart';
+import 'package:meta/meta.dart';
 import 'package:sembast/sembast.dart';
 
 /// Handles the local persistence to the database
@@ -139,7 +140,8 @@ class DatabaseRepositoryImpl implements DatabaseRepository {
   }
 }
 
-extension on DatabaseStore {
+extension StoreKeys on DatabaseStore {
+  @visibleForTesting
   String get key {
     switch (this) {
       case DatabaseStore.decks:

diff --git a/lib/data/sembast_database.dart b/lib/data/sembast_database.dart
@@ -9,22 +9,19 @@ import 'package:sembast/sembast_io.dart';
 const _schemaVersion = 1;
 const _dbName = 'memo_sembast.db';
 
-/// Opens this application's [Database], creating a new one if non-existing
+/// Opens this application's [Database], creating a new one if nonexistent
 Future<Database> openDatabase() async {
   final dir = await getApplicationDocumentsDirectory();
   // Make sure that the application documents directory exists
   await dir.create(recursive: true);
 
   final dbPath = path.join(dir.path, _dbName);
 
-  return databaseFactoryIo.openDatabase(dbPath, version: _schemaVersion, onVersionChanged: _applyMigrations);
+  return databaseFactoryIo.openDatabase(dbPath, version: _schemaVersion, onVersionChanged: applyMigrations);
 }
 
-Future<void> _applyMigrations(Database db, int oldVersion, int newVersion) async {
-  if (oldVersion == newVersion) {
-    return SynchronousFuture(null);
-  }
-
+@visibleForTesting
+Future<void> applyMigrations(Database db, int oldVersion, int newVersion) async {
   // Call the necessary migrations in order
 }