This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Support Label Selector and Namespace whitelisting. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 80fafa6 into 2c7e15d - view on LGTM.com new alerts:
|
gkope
approved these changes
Jan 16, 2020
deadc
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you require to create Cluster wide role and rolebinding . in addition to that it publishes all pods which require lot more resources in bigger clusters. Using Whitelist namespace you can just create namespaced based rolebinding which allows secure metrics scraping. Label Selector allows scape and publish necessary metrics.