Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/build commonjs without globals #24

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Hotfix/build commonjs without globals #24

merged 3 commits into from
Jan 21, 2021

Conversation

shinrox
Copy link
Contributor

@shinrox shinrox commented Jan 20, 2021

What
Do not include globals when building for commonjs

Why
The code doesn't use window and building like this generates errors when loading the plugin in SSR

@shinrox shinrox added the in review Extra attention is needed label Jan 20, 2021
@shinrox shinrox requested a review from a team January 20, 2021 21:19
@shinrox shinrox self-assigned this Jan 20, 2021
brunosaantos
brunosaantos approved these changes Jan 20, 2021
View reviewed changes
Copy link

@brunosaantos brunosaantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@shinrox shinrox merged commit 689a9fb into master Jan 21, 2021
@shinrox shinrox deleted the hotfix/build-commonjs-without-globals branch January 21, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayramartins nayramartins nayramartins approved these changes

@brunosaantos brunosaantos brunosaantos approved these changes

Assignees

@shinrox shinrox

Labels
in review Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shinrox @brunosaantos @nayramartins