Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add a configuration file. #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Core] Add a configuration file. #19

wants to merge 1 commit into from

Conversation

hobbestigrou
Copy link
Contributor

Give the possiblity to configure if the user must be staff.

Fixes: #17

@hobbestigrou hobbestigrou force-pushed the 17-add_a_settings_require_staff branch from 1302bb2 to da61d38 Compare March 23, 2018 16:55
@hobbestigrou
Copy link
Contributor Author

Did you agree with that ? Or did you want I make some modifications

@omarish
Copy link
Owner

omarish commented Mar 30, 2018

Nice, I think it's great so far, but we could probably simplify it a little bit by:

  1. Move the contents of conf.py into django's settings.py module.
  2. Update the main middleware file to check if settings.py hasattr CPROFILE_MIDDLEWARE_REQUIRE_STAFF, and default to True. That way we won't have to keep a separate conf.py file in the repository, and a user can update the library to not require staff by defining an option in settings.py.

Does that make sense? Thoughts?

@hobbestigrou
Copy link
Contributor Author

I prefer to have a separate file, but I'm going to make what you said.

@hobbestigrou hobbestigrou force-pushed the 17-add_a_settings_require_staff branch from 6c90975 to 62ebe9b Compare April 3, 2018 09:58
@hobbestigrou
Copy link
Contributor Author

I made the modification.

@hobbestigrou
[Core] Add a configuration file.
62ebe9b 
Give the possiblity to configure if the user must be staff.

Fixes: omarish#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbestigrou @omarish