Set the profiler instance on the request, not the middleware #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django only instantiates middleware once. This means that if the profiler is set as a middleware instance variable, concurrent requests will mess with each other. Setting the profiler on the request fixes that.
ddrake
pushed a commit
to ddrake/django-cprofile-middleware
that referenced
this pull request
Sep 28, 2023
This fix was proficed by ahumeau in pull request omarish#23 of the original repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django only instantiates middleware once. This means that if
the profiler is set as a middleware instance variable,
concurrent requests will mess with each other. Setting the profiler
on the request fixes that.