Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the the original PostgreSQL configuration file #41
base: master
Are you sure you want to change the base?
Use the the original PostgreSQL configuration file #41
Changes from 8 commits
82efa2d
3637a0e
35930b0
0879c9f
9ee77fa
9790b98
743d5f3
dcaa4eb
8151508
5b1c41a
bc2b2ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 55 in defaults/main.yml
Check failure on line 55 in defaults/main.yml
yaml[trailing-spaces]
Check failure on line 55 in defaults/main.yml
Check failure on line 55 in defaults/main.yml
yaml[trailing-spaces]
Check failure on line 67 in defaults/main.yml
Check failure on line 67 in defaults/main.yml
Check failure on line 69 in defaults/main.yml
Check failure on line 69 in defaults/main.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to have a hard fail in case
conf_sample_file
does not exist?Are you aware of any scenario where this file could legitimately be expected to be missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On our RHEL 9 test machine, there are 4 PostgreSQL versions have been installed (13, 14, 15, 16). Only version 16 folder has the sample file and the others do not have this file. I am not sure how these versions have been installed but I think the file should be there. I am not sure why it is missing. So, I have added the logic of downloading and extracting the file to account for similar cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting (and slightly concerning). Note all of the PSQL sample configuration file checks seem to be currently skipped in the Molecule tests on both Rocky Linux. I don't know if that's expected or indicates another issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will check for the sample file if the original file does not exist and the configuration file has been edited before, i.e. in case of installing the same PostgreSQL version with a previous role version.
Check warning on line 3 in tasks/initialise.yml
Check warning on line 3 in tasks/initialise.yml
Check failure on line 32 in tasks/initialise.yml
Check failure on line 32 in tasks/initialise.yml
Check failure on line 38 in tasks/initialise.yml
Check failure on line 38 in tasks/initialise.yml
Check warning on line 49 in tasks/initialise.yml
Check warning on line 49 in tasks/initialise.yml
Check failure on line 60 in tasks/initialise.yml
Check failure on line 60 in tasks/initialise.yml