Warn if relative units are encountered for a physical length

ome · Sep 13, 2024 · c7e9161 · c7e9161
1 parent ab8234f
commit c7e9161
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/components/formats-bsd/src/loci/formats/out/DicomWriter.java b/components/formats-bsd/src/loci/formats/out/DicomWriter.java
@@ -2082,7 +2082,12 @@ private short[] makeShortArray(int v) {
    * proper physical units (e.g. mm), so need to be handled specially.
    */
   private Length fixUnits(Length size) {
-    if (size == null || size.unit() == UNITS.PIXEL || size.unit() == UNITS.REFERENCEFRAME) {
+    if (size == null) {
+      return null;
+    }
+    if (size.unit() == UNITS.PIXEL || size.unit() == UNITS.REFERENCEFRAME) {
+      LOGGER.warn("Found physical length '{}' in relative units '{}'; this value will be lost",
+        size.value(), size.unit());
       return null;
     }
     return size;