Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PerkinElmer Operetta data #22

Merged
merged 2 commits into from
Feb 16, 2012

Conversation

melissalinkert
Copy link
Member

Closes #7254.

To test, please run:

ant -Dtestng.directory=$DATA/perkinelmer-operetta test-automated

Closes #7254.

To test, please run:

ant -Dtestng.directory=$DATA/perkinelmer-operetta test-automated
@chris-allan
Copy link
Member

Based on looking at Plate 1(2)__2011-09-29T23_50_20-Measurement1 it would appear that row and column offsets for the format are one-based, not zero-based. What should be A1 is showing up as B2. For OMERO.insight @jburel we will also have to extend the list of formats included in the import dialog file format restriction. How are the existing formats being picked up now?

@jburel
Copy link
Member

jburel commented Jan 29, 2012

@chris-allan, @melissalinkert: list of formats is returned by B-F i.e. loci.formats.gui.GUITools.buildFileFilters

@chris-allan
Copy link
Member

@jburel: Sure, I realise that. What does the filtering though? There are only 8 file filters or so available when importing into a Screen.

Noticed by Chris Allan.
@melissalinkert
Copy link
Member Author

@chris-allan Above commit should fix the well indexing.

@jburel Could the list of HCS readers be built by checking each reader's domain? Something like this: melissalinkert/openmicroscopy@5e2c799?

@jburel
Copy link
Member

jburel commented Feb 5, 2012

@melissalinkert: The approach suggested does not work, the method reader.getDomains() returns an exception indicating that the setId() method has to be called first.
Adjustment required: use reader.getPossibleDomains(String) instead of reader.getDomains()

@jburel
Copy link
Member

jburel commented Feb 5, 2012

@melissalinkert, @chris-allan: fix now implemented in sprint8-insight branch.

@chris-allan
Copy link
Member

All looking good. Merging.

chris-allan added a commit that referenced this pull request Feb 16, 2012
Add support for PerkinElmer Operetta data
@chris-allan chris-allan merged commit 6999f2c into ome:develop Feb 16, 2012
mtbc pushed a commit to mtbc/bioformats that referenced this pull request Oct 30, 2014
Units length physical size - looked over by @joshmoore, nothing major spotted
sbesson added a commit to sbesson/bioformats that referenced this pull request Jul 7, 2020
…_idr

Operetta: fix metadata files logic to skip plate folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants