BFConvert: Ensure crop size is used for all series #4003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to an issue reported on https://forum.image.sc/t/bfconvert-throwing-an-error-for-an-vsi-file/37185/7
I was able to reproduce the same exception with Bio-Formats 6.13.0 and the file from https://downloads.openmicroscopy.org/images/OME-TIFF/2016-06/sub-resolutions/Brightfield/Leica-1/
Without this PR, running the below command will result in an exception:
bfconvert -crop 0,0,512,512 Leica-1.ome.tiff Leica-1-crop.ome.tiff
This is due to ImageConverter failing to correctly set the adjusted cropped dimensions for any series other than the first.
To test, rerun the above scenario and the conversion should complete without exception. The converted file should be able to open and display, with the correct cropped dimensions being used for each series.