Ventana: fix tile arithmetic for smallest resolutions #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ome#3927. This makes the rounding consistent across all tile size and coordinate calculations, which should eliminate off-by-ones that cause a grid of black pixels to appear for the smallest few resolutions.
dgault
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Tested with curated/ventana/gh-3927 and saw the same results for other files in the curated Ventana datasets.
Without the PR attempting to open the lowest resolution resulted in the grid like pattern appearing on the images.
With the PR included the image now opens and displays as expected without the same pattern. The image dimensions and metadata remain unaffected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927.
Any of the .bif files in
curated/ventanashould show the issue, but the 3 files for which the problem was reported are incurated/ventana/gh-3927. Without this PR,showinf -noflaton the last 2 resolutions in the first series should show a grid of 0-value pixels. With this PR, the same command should show a normal-looking image that matches the larger resolutions in the pyramid.