ImageInfo: only call System.exit in batch mode #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to run showinf in batch mode introduced in Bio-Formats 8 has caused some regression with the interactivity of the utility when opening a single image without the -nopix option as the System.exit call immediately closes the viewer. This commit addresses the issue by only invoking it when multiple input are passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to run showinf in batch mode introduced in Bio-Formats 8 has caused some regression with the interactivity of the utility when opening a single image without the -nopix option as the System.exit call immediately closes the viewer. This commit addresses the issue by only invoking it when multiple input are passed.
To test this PR run
showinf test.fake. Without 8.0.0, the viewer should launch and terminate immediately. With this PR included the viewer should remain active until closed. The behavior of the utility when using the batch mode is unmodified.As discussed with Melissa, given this is a regression, this might be a candidate for a 8.0.1 release in the upcoming weeks